| Summary: | WKContentView might get KVO notifications it doesn't expect | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2020-11-04 03:46:12 PST
Created attachment 413154 [details]
Patch
Comment on attachment 413154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413154&action=review > Source/WebKit/ChangeLog:3 > + WKContextView might get KVO notifications it doesn't expect I think the title means WKContentView > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:739 > - [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:nil]; > + [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:WKContentViewKVOTransformContext]; Should we use the context in the deregistration too? I feel like there is some documented benefit. Comment on attachment 413154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413154&action=review >> Source/WebKit/ChangeLog:3 >> + WKContextView might get KVO notifications it doesn't expect > > I think the title means WKContentView Yep! Thanks. >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:739 >> + [self.layer addObserver:self forKeyPath:@"transform" options:NSKeyValueObservingOptionInitial context:WKContentViewKVOTransformContext]; > > Should we use the context in the deregistration too? I feel like there is some documented benefit. OK! Committed r269372: <https://trac.webkit.org/changeset/269372> |