| Summary: | Link against the ANGLE Shared Library | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, ews-watchlist, graouts, kondapallykalyan, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 224532 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dean Jackson
2020-11-03 15:36:45 PST
Created attachment 413115 [details]
Patch
Comment on attachment 413115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review > Source/WebCore/Configurations/WebCore.xcconfig:43 > +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks "Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine. > Source/WebCore/Configurations/WebCore.xcconfig:72 > +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared; Is this ... really the right syntax? It looks super weird! Comment on attachment 413115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review >> Source/WebCore/Configurations/WebCore.xcconfig:43 >> +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks > > "Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine. I guess it could be FRAMEWORKS. >> Source/WebCore/Configurations/WebCore.xcconfig:72 >> +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared; > > Is this ... really the right syntax? It looks super weird! I believe it is. At least.... it's working :) Committed r269344: <https://trac.webkit.org/changeset/269344> Committed r270064: <https://trac.webkit.org/changeset/270064> Reverted r270064 for reason: Broke the macCatayst build Committed r270121: <https://trac.webkit.org/changeset/270121> Created attachment 423654 [details]
Patch
Now that https://bugs.webkit.org/show_bug.cgi?id=223499 is fixed, this should be good to go. |