Bug 218530

Summary: align-content should be a discrete animatable property
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2020-11-03 12:40:57 PST
align-content should be a discrete animatable property
Attachments
Patch (12.50 KB, patch)
2020-11-03 12:42 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.54 KB, patch)
2020-11-03 13:37 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-11-03 12:42:12 PST
Created attachment 413093 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-11-03 13:00:32 PST
Comment on attachment 413093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413093&action=review > Source/WebCore/rendering/style/StyleContentAlignmentData.cpp:17 > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + * > + * You should have received a copy of the GNU Library General Public License > + * along with this library; see the file COPYING.LIB. If not, write to > + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + * Boston, MA 02110-1301, USA. Wrong license.
Antoine Quint
Comment 3 2020-11-03 13:37:13 PST
Created attachment 413102 [details] Patch for landing
Radar WebKit Bug Importer
Comment 4 2020-11-03 13:39:27 PST
<rdar://problem/71009339>
EWS
Comment 5 2020-11-03 14:17:20 PST
Committed r269333: <https://trac.webkit.org/changeset/269333> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413102 [details].
Note You need to log in before you can comment on or make changes to this bug.