Bug 218522

Summary:

[WinCairo/PlayStation] ICU 68.1 no longer exposes FALSE and TRUE macros by default

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, don.olmstead, ews-watchlist, gyuyoung.kim, luiz, noam, ryuan.choi, sergio, webkit-bug-importer, zeno

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Stephan Szabo 2020-11-03 10:21:04 PST

ICU 68.1 has stopped defining TRUE and FALSE macros by default (you can turn it on with a define, however it's also described as deprecated in some places).

Building using ICU 68.1 for WinCairo and PlayStation shows some places that fail to build without the definitions.

Comment 1 Stephan Szabo 2020-11-03 10:25:55 PST

Created attachment 413070 [details]
Patch

Comment 2 EWS 2020-11-03 12:06:21 PST

Committed r269325: <https://trac.webkit.org/changeset/269325>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413070 [details].

Comment 3 Radar WebKit Bug Importer 2020-11-03 12:07:23 PST

<rdar://problem/71005244>