Bug 218468

Summary: Regression(r269227) imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218363    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-11-02 16:16:16 PST 
imported/w3c/web-platform-tests/service-workers/service-worker/referrer-toplevel-script-fetch.https.html is a flaky crash since r269227.
Comment 1 Chris Dumez 2020-11-02 16:16:26 PST 
<rdar://problem/70969071>
Comment 2 Chris Dumez 2020-11-02 16:19:33 PST 
Created attachment 412986 [details]
Patch
Comment 3 Darin Adler 2020-11-02 16:40:38 PST 
Comment on attachment 412986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412986&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:116
> +                auto* context = scriptExecutionContext();
> +                if (!context)
> +                    return;
> +
> +                auto registration = ServiceWorkerRegistration::getOrCreate(*context, *this, WTFMove(registrationData));

Not sure this needs a blank line.
Comment 4 Chris Dumez 2020-11-02 16:42:30 PST 
Created attachment 412988 [details]
Patch
Comment 5 EWS 2020-11-02 17:15:19 PST 
Committed r269281: <https://trac.webkit.org/changeset/269281>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412988 [details].