Bug 218447

Summary: [Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Sam Weinig 2020-11-02 08:56:06 PST 
[Testing] Match WebKitTestRunner and enable all "experimental" features in DumpRenderTree (cocoa)
Comment 1 Sam Weinig 2020-11-02 09:01:15 PST Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-11-02 09:58:54 PST Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-11-02 10:43:19 PST Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-11-02 10:59:35 PST Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-11-02 11:53:28 PST Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-11-02 12:10:16 PST 
Created attachment 412958 [details]
Patch
Comment 7 Sam Weinig 2020-11-02 13:21:52 PST 
Created attachment 412963 [details]
Patch
Comment 8 Darin Adler 2020-11-02 14:56:24 PST 
Comment on attachment 412963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412963&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:901
> +    [preferences setEncryptedMediaAPIEnabled:YES];
> +    [preferences setGamepadsEnabled:YES];
> +    [preferences setLinkPreloadEnabled:YES];
> +    [preferences setMediaPreloadingEnabled:YES];
> +    [preferences setColorFilterEnabled:YES];

What’s the significance of the ordering here? If there’s none, then I suggest sorting.
Comment 9 EWS 2020-11-02 16:05:25 PST 
Committed r269278: <https://trac.webkit.org/changeset/269278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412963 [details].
Comment 10 Radar WebKit Bug Importer 2020-11-02 16:06:52 PST 
<rdar://problem/70970524>
Comment 11 Sam Weinig 2020-11-02 16:10:04 PST 
(In reply to Darin Adler from comment #8)
> Comment on attachment 412963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412963&action=review
> 
> > Tools/DumpRenderTree/mac/DumpRenderTree.mm:901
> > +    [preferences setEncryptedMediaAPIEnabled:YES];
> > +    [preferences setGamepadsEnabled:YES];
> > +    [preferences setLinkPreloadEnabled:YES];
> > +    [preferences setMediaPreloadingEnabled:YES];
> > +    [preferences setColorFilterEnabled:YES];
> 
> What’s the significance of the ordering here? If there’s none, then I
> suggest sorting.

There was none. Put a patch up to sort everything in the function at https://bugs.webkit.org/show_bug.cgi?id=218467.