| Summary: | [GTK][WPE] Cannot remove individual scripts/stylesheets using WebKitUserContentManager | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||
| Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, jan.brummer, mcatanzaro | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 412796 [details]
WIP Patch
This should work, modulo missing test cases,
which I will be adding if people agree we want to do these
two additions to the public API ^_^
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API LGTM. I guess Ephy ought to use this when its user script/style preferences are disabled? Yes, we need it there and also for my WebExtensions branch. Created attachment 412919 [details]
Patch
Committed r269287: <https://trac.webkit.org/changeset/269287> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412919 [details]. |
Currently there are webkit_user_content_manager_remove_filter[_by_id] but no equivalent for scripts and stylesheets. There is no reason why webkit_user_content_manager_remove_{script,style_sheet} shouldn't be available >_<