Bug 218382

Summary: WebDriver: session can have more than one active input source of the same type
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 166679    
Attachments:
Description Flags
Patch bburg: review+

Description Carlos Garcia Campos 2020-10-30 06:47:55 PDT
We are failing in that case, and the dispatcher assumes it's not possible, but the spec doesn't say there's such limitation and there's a WPT infrastructure test checking that (infrastructure/testdriver/actions/eventOrder.html).
Comment 1 Carlos Garcia Campos 2020-10-30 06:54:55 PDT
Created attachment 412737 [details]
Patch
Comment 2 BJ Burg 2020-11-04 11:41:15 PST
Comment on attachment 412737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412737&action=review

r=me, good catch.

> Source/WebDriver/ChangeLog:8
> +        Only send to the browser the list of input sources actually used by the action sequence.

I checked, and this is indeed what safaridriver already does on its side.
Comment 3 Carlos Garcia Campos 2020-11-05 00:45:54 PST
Committed r269419: <https://trac.webkit.org/changeset/269419>
Comment 4 Radar WebKit Bug Importer 2020-11-05 00:46:23 PST
<rdar://problem/71069264>