| Summary: | Align GBK and gb18030 encoder and decoder with specification and other browsers | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> | ||||||||||
| Component: | DOM | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, clopez, ddkilzer, ews-watchlist, mmaxfield, smoley, webkit-bug-importer, youennf, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Anne van Kesteren
2020-10-30 04:21:44 PDT
Thanks for filing, if you have any other info to make this more actionable like a test case and steps to reproduce the issue (or lack of error in this case) please add it here. (In reply to Smoley from comment #2) > Thanks for filing, if you have any other info to make this more actionable > like a test case and steps to reproduce the issue (or lack of error in this > case) please add it here. Well, Anne provided the tests in the bug description: https://github.com/web-platform-tests/wpt/pull/26317 Created attachment 413008 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 413009 [details]
Patch
Nice! Do you think we should file a bug to ICU about this encoding? Created attachment 413064 [details]
Patch
(In reply to Yusuke Suzuki from comment #7) > Nice! Do you think we should file a bug to ICU about this encoding? This is one of many encodings where ICU differs from all browsers. I'm planning to give them a report. The tests I wrote have been submitted in a PR to wpt https://github.com/web-platform-tests/wpt/pull/26385 Comment on attachment 413064 [details]
Patch
r=me. Please file bug reports for issues found in ICU, too.
Created attachment 413210 [details]
Patch
(In reply to Alex Christensen from comment #12) > Created attachment 413210 [details] > Patch What changed? I added another test showing the GBK decoding differences with Chromium. Committed r269499: <https://trac.webkit.org/changeset/269499> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413210 [details]. |