Bug 218358

Summary: [GLIB] REGRESSION(r269144) imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html is failing
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, macpherson, menard, mrobinson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218076
Attachments:
Description Flags
Patch none

Description Lauro Moura 2020-10-29 14:58:24 PDT 
imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin.html

r269144 updated the expectations but the test is still giving the old results, both in the bots and locally.

Diff:

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/cssom-view/scrollIntoView-scrollMargin-actual.txt
@@ -1,5 +1,5 @@
 
-PASS scrollIntoView({block: "center", inline: "center"})
-PASS scrollIntoView({block: "start", inline: "start"})
-PASS scrollIntoView({block: "end", inline: "end"})
+FAIL scrollIntoView({block: "center", inline: "center"}) assert_approx_equals: scrollX expected 153.5 +/- 0.5 but got 158
+FAIL scrollIntoView({block: "start", inline: "start"}) assert_approx_equals: scrollX expected 184 +/- 0.5 but got 200
+FAIL scrollIntoView({block: "end", inline: "end"}) assert_approx_equals: scrollX expected 123 +/- 0.5 but got 115
Comment 1 Lauro Moura 2020-10-29 15:04:52 PDT 
Gardened in r269172
Comment 2 Martin Robinson 2020-10-30 02:52:34 PDT 
Created attachment 412727 [details]
Patch
Comment 3 Martin Robinson 2020-10-30 02:53:08 PDT 
It seems that I did not fully expose scroll-margin when ENABLE_SCROLL_SNAP was disabled. I believe that this patch fixes the issue.
Comment 4 Lauro Moura 2020-10-30 06:10:55 PDT 
(In reply to Martin Robinson from comment #3)
> It seems that I did not fully expose scroll-margin when ENABLE_SCROLL_SNAP
> was disabled. I believe that this patch fixes the issue.

Tested the patch with the css-om suite and indeed it fixes the issue with no regressions.

Thanks!
Comment 5 EWS 2020-11-02 06:59:27 PST 
Committed r269246: <https://trac.webkit.org/changeset/269246>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412727 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-02 07:00:22 PST 
<rdar://problem/70948378>