Bug 218351

Summary: Resync web-platform-tests/resources tests from upstream
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, darin, eric.carlson, ews-watchlist, ggaren, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2020-10-29 13:28:53 PDT
Resync web-platform-tests/resources tests from upstream.
Comment 1 Chris Dumez 2020-10-29 13:31:13 PDT
Created attachment 412680 [details]
Patch
Comment 2 Chris Dumez 2020-10-29 14:23:32 PDT
Created attachment 412685 [details]
Patch
Comment 3 Sam Weinig 2020-10-29 14:33:09 PDT
Comment on attachment 412685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412685&action=review

> LayoutTests/imported/w3c/web-platform-tests/resources/chromium/README.md:1
> +This directory contains Chromium-specific test resources, including mocks for

I realize this was already here, but why do we have this imported? If they are Chromium specific, doesn't seem like we need them.
Comment 4 Chris Dumez 2020-10-29 14:50:33 PDT
Created attachment 412690 [details]
Patch
Comment 5 Chris Dumez 2020-10-29 14:51:14 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 412685 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412685&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/resources/chromium/README.md:1
> > +This directory contains Chromium-specific test resources, including mocks for
> 
> I realize this was already here, but why do we have this imported? If they
> are Chromium specific, doesn't seem like we need them.

Ok. Dropping them in this latest iteration. Hopefully tests still pass :o)
Comment 6 Sam Weinig 2020-10-29 21:13:44 PDT
Comment on attachment 412690 [details]
Patch

rs=me
Comment 7 Chris Dumez 2020-10-30 07:36:39 PDT
Created attachment 412741 [details]
Patch
Comment 8 EWS 2020-10-30 08:32:54 PDT
Committed r269186: <https://trac.webkit.org/changeset/269186>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412741 [details].
Comment 9 Radar WebKit Bug Importer 2020-10-30 08:33:20 PDT
<rdar://problem/70877741>