| Summary: | Add some logging to SequenceCheckerImpl::IsCurrent | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2020-10-29 03:44:55 PDT
Created attachment 412629 [details]
Patch
Comment on attachment 412629 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412629&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_checker.cc:63 > + if (valid_queue_ != current_queue) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing"; > return valid_queue_ == current_queue; > } > if (valid_system_queue_ && valid_system_queue_ == current_system_queue) { > + if (valid_queue_ != current_queue) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is failing"; > return true; > } > - return rtc::IsThreadRefEqual(valid_thread_, current_thread); > + auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread); > + if (!result) > + RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing"; Would it be helpful have unique log strings to help identify which check fails? > Would it be helpful have unique log strings to help identify which check
> fails?
These strings are each different so we should know which one is failing.
Committed r269156: <https://trac.webkit.org/changeset/269156> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412629 [details]. |