Bug 218308

Summary:

Resync web-platform-tests/payment-request tests from upstream

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, aestes, clopez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, marcos, philipj, sam, sergio, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=175611

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2020-10-28 15:13:00 PDT

Resync web-platform-tests/payment-request tests from upstream.

Attachments
Patch (258.20 KB, patch) 2020-10-28 15:21 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (268.32 KB, patch) 2020-10-29 08:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (269.75 KB, patch) 2020-10-29 13:21 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2020-10-28 15:21:23 PDT

Created attachment 412576 [details] Patch

Chris Dumez

Comment 2 2020-10-29 08:36:42 PDT

Created attachment 412652 [details] Patch

Geoffrey Garen

Comment 3 2020-10-29 09:33:37 PDT

Comment on attachment 412652 [details] Patch rs=me

Chris Dumez

Comment 4 2020-10-29 13:21:15 PDT

Created attachment 412677 [details] Patch

Chris Dumez

Comment 5 2020-10-29 13:24:02 PDT

Comment on attachment 412677 [details] Patch Clearing flags on attachment: 412677 Committed r269164: <https://trac.webkit.org/changeset/269164>

Chris Dumez

Comment 6 2020-10-29 13:24:05 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2020-10-29 13:25:21 PDT

<rdar://problem/70822990>

Truitt Savell

Comment 8 2020-11-02 14:31:18 PST

imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https.html is a flaky failure after its move. Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects.https-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test FAIL Rejection of detailsPromise must abort the update with an 'AbortError' DOMException. promise_rejects_dom: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." that is not a DOMException AbortError: property "code" is equal to 18, expected 20 FAIL Total in the update is a string, so converting to IDL must abort the update with a TypeError. promise_rejects_js: badDetails must cause acceptPromise to reject with expectedError function "function () { throw e }" threw object "SecurityError: show() must be triggered by user activation." ("SecurityError") expected instance of function "function TypeError() {

Chris Dumez

Comment 9 2020-11-02 14:36:00 PST

(In reply to Truitt Savell from comment #8) > imported/w3c/web-platform-tests/payment-request/show-method-optional-promise- > rejects.https.html > > is a flaky failure after its move. > > > > Diff: > --- > /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/payment-request/show-method-optional-promise- > rejects.https-expected.txt > +++ > /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/payment-request/show-method-optional-promise- > rejects.https-actual.txt > @@ -1,3 +1,4 @@ > +CONSOLE MESSAGE: Unhandled Promise Rejection: SyntaxError: test > > FAIL Rejection of detailsPromise must abort the update with an 'AbortError' > DOMException. promise_rejects_dom: badDetails must cause acceptPromise to > reject with expectedError function "function () { throw e }" threw object > "SecurityError: show() must be triggered by user activation." that is not a > DOMException AbortError: property "code" is equal to 18, expected 20 > FAIL Total in the update is a string, so converting to IDL must abort the > update with a TypeError. promise_rejects_js: badDetails must cause > acceptPromise to reject with expectedError function "function () { throw e > }" threw object "SecurityError: show() must be triggered by user > activation." ("SecurityError") expected instance of function "function > TypeError() { Fixed in <https://trac.webkit.org/changeset/269276>, thanks.

Note You need to log in before you can comment on or make changes to this bug.