| Summary: | Rename build.webkit.org-config directory to build-webkit-org | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, clopez, don.olmstead, Hironori.Fujii, jbedard, ryanhaddad, stephan.szabo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=218026 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 175056 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-10-28 11:46:50 PDT
Created attachment 412555 [details]
Patch
Comment on attachment 412555 [details]
Patch
Are we doing anything with symlinks here? Do we need to?
Are the files that didn't seem to move in the patch (like the README) unnecessary now? (In reply to Stephan Szabo from comment #3) > Are the files that didn't seem to move in the patch (like the README) unnecessary now? I did "svn mv build.webkit.org-config build-webkit-org". So there shouldn't be any such files. README is also moved in this patch. Maybe the patch review UI doesn't show it properly. (In reply to Jonathan Bedard from comment #2) > Are we doing anything with symlinks here? Do we need to? Doesn't look like we need to create symlink for this. There aren't much external directories referencing this. build-webkit-org/steps.py reference it in RunDashboardTests and ews-build/steps.py reference it in RunBuildWebKitOrgUnitTests. For those we can just restart Buildbot to pick up new location. Committed r269120: <https://trac.webkit.org/changeset/269120> (In reply to Aakash Jain from comment #0) > Note that "build.webkit.org" directory name isn't a good option, since in > the long-term we want to run build.webkit.org unit-tests using test-webkitpy > script and that requires directory name to not have dots. It would be great to run the buildbot unit-tests with test-webkitpy :) Restarted build.webkit.org to pick up this change. Seems to be working fine. |