Bug 218293

Summary: AX: Incorrect list of voices being displayed on iOS
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, pvollan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
ews-feeder: commit-queue-
patch
ews-feeder: commit-queue-
patch
ews-feeder: commit-queue-
patch
none
patch
none
patch
none
patch
none
patch
pvollan: review+
patch none

Description chris fleizach 2020-10-28 10:45:06 PDT 
For WebSpeech, we want WebKit to only show built-in system voices.

<rdar://problem/70741038>
Comment 1 chris fleizach 2020-10-28 10:47:24 PDT 
Created attachment 412545 [details]
patch
Comment 2 chris fleizach 2020-10-28 11:06:17 PDT 
Created attachment 412547 [details]
patch
Comment 3 chris fleizach 2020-10-28 11:51:55 PDT 
Created attachment 412557 [details]
patch
Comment 4 chris fleizach 2020-10-28 13:09:30 PDT 
Created attachment 412565 [details]
patch
Comment 5 chris fleizach 2020-10-28 13:27:10 PDT 
Created attachment 412568 [details]
patch
Comment 6 chris fleizach 2020-10-28 17:22:22 PDT 
Created attachment 412592 [details]
patch
Comment 7 chris fleizach 2020-10-29 10:17:04 PDT 
Created attachment 412664 [details]
patch
Comment 8 chris fleizach 2020-10-29 14:26:22 PDT 
Created attachment 412687 [details]
patch
Comment 9 Per Arne Vollan 2020-10-30 11:22:28 PDT 
Comment on attachment 412687 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412687&action=review

R=me.

> Source/WebCore/PAL/pal/spi/cocoa/AXSpeechManagerSPI.h:38
> +WTF_EXTERN_C_BEGIN

I don't think this is needed when you're declaring an interface.
Comment 10 chris fleizach 2020-10-30 11:25:43 PDT 
Created attachment 412779 [details]
patch

addressed review comments
Comment 11 EWS 2020-10-30 15:59:15 PDT 
Committed r269208: <https://trac.webkit.org/changeset/269208>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412779 [details].