| Summary: | AudioBuffer.getChannelData(x) should keep returning the same JS wrapper for a given channel | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, jer.noble, kondapallykalyan, philipj, sam, sergio, webkit-bug-importer, ysuzuki | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 212611, 218286 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2020-10-27 15:42:23 PDT
Created attachment 412469 [details]
Patch
Comment on attachment 412469 [details]
Patch
Build errors.
Created attachment 412470 [details]
Patch
Created attachment 412473 [details]
Patch
Comment on attachment 412473 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412473&action=review r=me > Source/WebCore/Modules/webaudio/AudioBuffer.cpp:156 > +void AudioBuffer::visitChannelsWrappers(JSC::SlotVisitor& visitor) Also visitChannelWrappers > Source/WebCore/Modules/webaudio/AudioBuffer.h:82 > + Vector<JSValueInWrappedObject> m_channelsWrappers; I would call this m_channelWrappers. Each wrapper wraps one channel. Created attachment 412475 [details]
Patch
Geoff Garren found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 412476 [details]
Patch
Committed r269081: <https://trac.webkit.org/changeset/269081> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412476 [details]. |