Bug 218263

Summary: Remove leftover DiagnosticLoggingKey after r268458
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Brent Fulgham 2020-10-27 14:25:04 PDT 
When we removed the old ITP telemetry in Bug 217665, we didn't remove the DiagnosticLoggingKey for this content.

To avoid future confusion, let's remove it.
Comment 1 Brent Fulgham 2020-10-27 14:26:05 PDT 
<rdar://problem/70738034>
Comment 2 Brent Fulgham 2020-10-27 14:28:40 PDT 
Created attachment 412465 [details]
Patch
Comment 3 Darin Adler 2020-10-27 14:31:34 PDT 
Comment on attachment 412465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412465&action=review

> Source/WebCore/ChangeLog:3
> +        REGRESSION(r268458): Remove leftover DiagnosticLoggingKey

Seems really strange to call this REGRESSION.

An unused function has no effect other than making the binary a little bigger.
Comment 4 Brent Fulgham 2020-10-27 14:34:26 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 412465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412465&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        REGRESSION(r268458): Remove leftover DiagnosticLoggingKey
> 
> Seems really strange to call this REGRESSION.
> 
> An unused function has no effect other than making the binary a little
> bigger.

Fair point -- I'll just reference the change where we forgot to remove this.
Comment 5 Brent Fulgham 2020-10-27 14:36:34 PDT 
Created attachment 412466 [details]
Patch for landing
Comment 6 EWS 2020-10-27 15:22:05 PDT 
Committed r269078: <https://trac.webkit.org/changeset/269078>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412466 [details].