Bug 218242

Summary: -Wparentheses warning in OptionsList.h
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: JavaScriptCoreAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2020-10-27 09:55:12 PDT 
In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-30.cpp:6:
../../Source/JavaScriptCore/runtime/Options.cpp: In static member function ‘static void JSC::Options::recomputeDependentOptions()’:
../../Source/JavaScriptCore/runtime/Options.cpp:539:25: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  539 |             if (!(flags & SupportsDFG))        \
../../Source/JavaScriptCore/runtime/OptionsList.h:574:5: note: in expansion of macro ‘DISABLE_TIERS’
  574 |     v(usePrivateClassFields, SupportsFTL | SupportsDFG, "https://bugs.webkit.org/show_bug.cgi?id=212781", "https://bugs.webkit.org/show_bug.cgi?id=212784")
      |     ^
../../Source/JavaScriptCore/runtime/Options.cpp:545:9: note: in expansion of macro ‘FOR_EACH_JSC_EXPERIMENTAL_OPTION’
  545 |         FOR_EACH_JSC_EXPERIMENTAL_OPTION(DISABLE_TIERS);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/JavaScriptCore/runtime/Options.cpp:541:25: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
  541 |             if (!(flags & SupportsFTL))        \
../../Source/JavaScriptCore/runtime/OptionsList.h:574:5: note: in expansion of macro ‘DISABLE_TIERS’
  574 |     v(usePrivateClassFields, SupportsFTL | SupportsDFG, "https://bugs.webkit.org/show_bug.cgi?id=212781", "https://bugs.webkit.org/show_bug.cgi?id=212784")
      |     ^
../../Source/JavaScriptCore/runtime/Options.cpp:545:9: note: in expansion of macro ‘FOR_EACH_JSC_EXPERIMENTAL_OPTION’
  545 |         FOR_EACH_JSC_EXPERIMENTAL_OPTION(DISABLE_TIERS);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Comment 1 Michael Catanzaro 2020-10-27 09:56:26 PDT 
Created attachment 412434 [details]
Patch
Comment 2 EWS 2020-10-27 10:54:49 PDT 
Committed r269054: <https://trac.webkit.org/changeset/269054>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412434 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-27 10:55:23 PDT 
<rdar://problem/70729394>