Bug 218223

Summary:

Update generate_xcfilelists to accommodate paths with symlinks

Product:

WebKit

Reporter:

Keith Rollin <krollin>

Component:

Tools / Tests

Assignee:

Keith Rollin <krollin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, jbedard, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Keith Rollin 2020-10-26 22:33:24 PDT

There are cases where file system paths are compared against each other, and where the comparisons are failing because one or the other (or both) make use of symlinks, causing paths that refer to the same location to fail to compare correctly. Address this by resolving path components that are symlinks.

Comment 1 Radar WebKit Bug Importer 2020-10-26 22:33:41 PDT

<rdar://problem/70709808>

Comment 2 Keith Rollin 2020-10-26 22:36:42 PDT

Created attachment 412392 [details]
Patch

Comment 3 Timothy Hatcher 2020-10-27 10:18:50 PDT

This fixed my issue, thanks!

Comment 4 EWS 2020-10-27 12:33:18 PDT

Committed r269063: <https://trac.webkit.org/changeset/269063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412392 [details].