Bug 218203

Summary: evictCodedFrames does extra work if RELEASE_LOG_DISABLED is set
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2020-10-26 13:57:51 PDT
We found on our port where we have RELEASE_LOG_DISABLED set that evictCodedFrames would sometimes evict after the current position even if it freed up enough space during the first part of the eviction. It looks like a log change from a while ago changed the block that checked whether the buffer was still full and to log and return to only happen if logging was not disabled which changed the behavior since the return no longer happened either.
Attachments
Patch (1.60 KB, patch)
2020-10-26 14:44 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-10-26 14:44:27 PDT
Created attachment 412356 [details] Patch
EWS
Comment 2 2020-10-26 16:47:23 PDT
Committed r269001: <https://trac.webkit.org/changeset/269001> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412356 [details].
Radar WebKit Bug Importer
Comment 3 2020-10-26 16:48:18 PDT
<rdar://problem/70701318>
Note You need to log in before you can comment on or make changes to this bug.