Bug 218196

Summary: Web Inspector: REGRESSION(r266695): Sources: override banner is squished for large images
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Before Patch
none
After Patch none

Description Devin Rousso 2020-10-26 10:30:17 PDT 
# STEPS TO REPRODUCE
1. inspect <https://webkit.org>
2. create an override for `template.svg`
Comment 1 Radar WebKit Bug Importer 2020-10-27 13:35:28 PDT 
<rdar://problem/70736428>
Comment 2 Patrick Angle 2020-11-04 18:19:05 PST 
Created attachment 413233 [details]
Patch
Comment 3 Patrick Angle 2020-11-04 18:23:02 PST 
Created attachment 413235 [details]
Before Patch
Comment 4 Patrick Angle 2020-11-04 18:23:14 PST 
Created attachment 413236 [details]
After Patch
Comment 5 Devin Rousso 2020-11-04 18:43:03 PST 
Comment on attachment 413233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413233&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        This is resolved by making sure the minimum dimensions of the image containers are 0, so that the container can
> +        be `flex-shrink`ed.

That's ... odd.  The fact that we have to add `min-width`/`min-height` really feels like a bug :(

Could we use `flex-shrink`/`flex-grow` instead (maybe also on the banner node too)?
Comment 6 Patrick Angle 2020-11-04 20:16:15 PST 
Comment on attachment 413233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413233&action=review

>> Source/WebInspectorUI/ChangeLog:11
>> +        be `flex-shrink`ed.
> 
> That's ... odd.  The fact that we have to add `min-width`/`min-height` really feels like a bug :(
> 
> Could we use `flex-shrink`/`flex-grow` instead (maybe also on the banner node too)?

I don't believe this is a bug; I just checked against FF and Chrome and observe the same behavior with a repro case, so really the previous behavior was a bug. Maybe I'm missing something, but no combination of flex-shrink and flex-grow is actually affecting the sizing in any meaningful way for me in any of the browsers.
Comment 7 EWS 2020-11-05 09:01:14 PST 
Committed r269438: <https://trac.webkit.org/changeset/269438>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413233 [details].