Bug 218175

Summary: [EME][GStreamer] Decode base64 init data if needed
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED INVALID    
Severity: Normal CC: cgarcia, ews-watchlist, gustavo, menard, pnormand, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218174    
Bug Blocks: 218238    
Attachments:
Description Flags
Patch
none
Patch none

Xabier Rodríguez Calvar
Reported 2020-10-26 04:13:10 PDT
[EME][GStreamer] Decode base64 init data if needed
Attachments
Patch (2.96 KB, patch)
2020-10-26 04:14 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2020-10-27 05:05 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2020-10-26 04:14:55 PDT
Created attachment 412304 [details] Patch
Philippe Normand
Comment 2 2020-10-26 04:40:15 PDT
Comment on attachment 412304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file.
Xabier Rodríguez Calvar
Comment 3 2020-10-26 09:26:15 PDT
(In reply to Philippe Normand from comment #2) > Comment on attachment 412304 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412304&action=review > > > Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 > > + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); > > Seems like this would work only because of unified builds? Can you declare a > dedicated log category for this module and make it default? It would reduce > macro verbosity and also be useful for the GST_ERROR call in this file. This is a header file. Declaring a default category seems a bad idea, right?
Xabier Rodríguez Calvar
Comment 4 2020-10-26 09:28:15 PDT
The build problem should be solved by landing patch for bug 218174 first.
Philippe Normand
Comment 5 2020-10-26 09:57:38 PDT
Comment on attachment 412304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412304&action=review >>> Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:81 >>> + GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_TRACE, nullptr, "payload size %zu", m_payload->size()); >> >> Seems like this would work only because of unified builds? Can you declare a dedicated log category for this module and make it default? It would reduce macro verbosity and also be useful for the GST_ERROR call in this file. > > This is a header file. Declaring a default category seems a bad idea, right? Not if you use GST_DEBUG_CATEGORY_EXTERN.
Xabier Rodríguez Calvar
Comment 6 2020-10-27 05:05:39 PDT
Created attachment 412411 [details] Patch
EWS
Comment 7 2020-10-27 06:00:46 PDT
Committed r269033: <https://trac.webkit.org/changeset/269033> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412411 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-27 06:01:22 PDT
<rdar://problem/70719469>
Xabier Rodríguez Calvar
Comment 9 2020-10-27 09:02:10 PDT
It looks this patch makes media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html timeout. I'm on it.
Xabier Rodríguez Calvar
Comment 10 2020-10-28 04:40:39 PDT
Reverted r269033 for reason: 269043 Committed r269097: <https://trac.webkit.org/changeset/269097>
Xabier Rodríguez Calvar
Comment 11 2020-10-28 04:48:14 PDT
This solution ain't good, I need to find another one. Reverted and closing.
Note You need to log in before you can comment on or make changes to this bug.