Bug 218159

Summary: JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage
Product: WebKit Reporter: Sam Weinig <sam>
Component: BindingsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, darin, esprehn+autocc, ews-watchlist, jsbell, keith_miller, kondapallykalyan, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Sam Weinig 2020-10-25 09:43:55 PDT 
JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage.
Comment 1 Sam Weinig 2020-10-25 09:49:31 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-25 14:00:45 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-25 14:27:35 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-25 14:34:51 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-10-25 18:23:29 PDT 
Created attachment 412284 [details]
Patch
Comment 6 EWS 2020-10-26 11:41:18 PDT 
Committed r268990: <https://trac.webkit.org/changeset/268990>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412284 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-26 11:42:37 PDT 
<rdar://problem/70688374>