Bug 218149

Summary: [BigSur] Appending a new WebM init segment between Cluster elements throws an error
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Jer Noble
Reported 2020-10-24 00:09:16 PDT
[Cocoa] Appending a new WebM init segment between Cluster elements throws an error
Attachments
Patch (731.04 KB, patch)
2020-10-24 00:22 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (731.97 KB, patch)
2020-10-24 11:05 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-10-24 00:22:10 PDT
Created attachment 412237 [details] Patch
Jer Noble
Comment 2 2020-10-24 00:23:02 PDT
<rdar://problem/70416537>
Eric Carlson
Comment 3 2020-10-24 09:51:35 PDT
Comment on attachment 412237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412237&action=review r=me once the bots are happy > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537 > + INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying"); Maybe ALWAYS_LOG_IF_POSSIBLE?
Jer Noble
Comment 4 2020-10-24 10:01:58 PDT
(In reply to Eric Carlson from comment #3) > Comment on attachment 412237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412237&action=review > > r=me once the bots are happy Yeah I need to skip these new tests on < BigSur > > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537 > > + INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying"); > > Maybe ALWAYS_LOG_IF_POSSIBLE? Sure.
Jer Noble
Comment 5 2020-10-24 11:05:21 PDT
Created attachment 412242 [details] Patch for landing
EWS
Comment 6 2020-10-24 12:30:50 PDT
Committed r268952: <https://trac.webkit.org/changeset/268952> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412242 [details].
Note You need to log in before you can comment on or make changes to this bug.