Bug 218149

Summary: [BigSur] Appending a new WebM init segment between Cluster elements throws an error
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2020-10-24 00:09:16 PDT 
[Cocoa] Appending a new WebM init segment between Cluster elements throws an error
Comment 1 Jer Noble 2020-10-24 00:22:10 PDT 
Created attachment 412237 [details]
Patch
Comment 2 Jer Noble 2020-10-24 00:23:02 PDT 
<rdar://problem/70416537>
Comment 3 Eric Carlson 2020-10-24 09:51:35 PDT 
Comment on attachment 412237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412237&action=review

r=me once the bots are happy

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537
> +        INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying");

Maybe ALWAYS_LOG_IF_POSSIBLE?
Comment 4 Jer Noble 2020-10-24 10:01:58 PDT 
(In reply to Eric Carlson from comment #3)
> Comment on attachment 412237 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412237&action=review
> 
> r=me once the bots are happy

Yeah I need to skip these new tests on < BigSur

> > Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537
> > +        INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while parsing Segment element. Rewound reader and reset parser, retrying");
> 
> Maybe ALWAYS_LOG_IF_POSSIBLE?

Sure.
Comment 5 Jer Noble 2020-10-24 11:05:21 PDT 
Created attachment 412242 [details]
Patch for landing
Comment 6 EWS 2020-10-24 12:30:50 PDT 
Committed r268952: <https://trac.webkit.org/changeset/268952>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412242 [details].