Bug 218137

Summary: REGRESSION (r260276): Unable to click on image and text link at the bottom of https://www.nytimes.com/ article
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, tsavell, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218209
Attachments:
Description Flags
Patch
zalan: review+, ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2020-10-23 14:24:55 PDT
REGRESSION (r260276): Unable to click on image and text link at the bottom of https://www.nytimes.com/ article
Comment 1 Simon Fraser (smfr) 2020-10-23 14:35:54 PDT
Created attachment 412212 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-10-23 14:35:57 PDT
<rdar://problem/70439526>
Comment 3 Simon Fraser (smfr) 2020-10-23 21:07:34 PDT
Created attachment 412229 [details]
Patch
Comment 4 EWS 2020-10-23 23:30:44 PDT
Committed r268947: <https://trac.webkit.org/changeset/268947>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412229 [details].
Comment 5 Truitt Savell 2020-10-26 14:49:32 PDT
Reverted r268947 for reason:

Caused 60 image failures on Catalina WK2

Committed r268997: <https://trac.webkit.org/changeset/268997>
Comment 6 Simon Fraser (smfr) 2020-10-26 14:51:13 PDT
(In reply to Truitt Savell from comment #5)
> Reverted r268947 for reason:
> 
> Caused 60 image failures on Catalina WK2
> 
> Committed r268997: <https://trac.webkit.org/changeset/268997>

It didn't directly cause image failures. It may have caused the testing harness to use the image result from the wrong test, or to interfere with snapshotting somehow, maybe.
Comment 7 EWS 2020-10-26 16:38:15 PDT
Committed r269000: <https://trac.webkit.org/changeset/269000>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412229 [details].