| Summary: | Rename slave to worker in webkitpy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224988 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 213092 | ||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-10-23 07:29:12 PDT
Created attachment 412177 [details]
Patch
Comment on attachment 412177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412177&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:578 > + build_worker = self._options.build_slave We will need to expose a "build_worker" option, change all our buildbot invocations, and then remove the "build_slave" option to totally get rid of this. (not particularly difficult, just going to take a few patches and a few buildbot restarts) Yeah. Committed r268925: <https://trac.webkit.org/changeset/268925> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412177 [details]. |