| Summary: | [css-logical] Add support for block/inline CSS values for resize property | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, joepeck, koivisto, kondapallykalyan, macpherson, menard, ntim, pdr, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari Technology Preview | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 185977 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2020-10-22 10:24:36 PDT
Created attachment 456342 [details]
Patch
Comment on attachment 456342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review > Source/WebCore/css/CSSProperties.json:-4267 > - "inherited": true, Not sure why this was set, but Resize was in StyleRare_Non_InheritedData.h, and per-spec it shouldn't be inherited anyway. Comment on attachment 456342 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review > Source/WebCore/rendering/RenderLayer.cpp:2791 > + canResizeWidth |= resize == Resize::Horizontal || resize == Resize::Both; Not a fan of using bitwise operators for boolean logic. Created attachment 456343 [details]
Patch
Created attachment 456345 [details]
Patch
Committed r292222 (249125@main): <https://commits.webkit.org/249125@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456345 [details]. |