| Summary: | [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, jiewen_tan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 181943 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2020-10-21 22:44:15 PDT
Created attachment 412069 [details]
Patch
Comment on attachment 412069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review I had a few suggestions, but looks good. r=me > Source/WebKit/Scripts/process-entitlements.sh:317 > +# elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements Did you mean to have this commented out? If so, please include a # FIXME() comment with the bug number to enable it. > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168 > + // If so, continue to the old route. Otherwise, use the modern WebAuthn process way. I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process. Comment on attachment 412069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review Thanks Brent for r+ this patch. >> Source/WebKit/Scripts/process-entitlements.sh:317 >> +# elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements > > Did you mean to have this commented out? > > If so, please include a # FIXME() comment with the bug number to enable it. Just forgot to uncomment it... Good catch! >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168 >> + // If so, continue to the old route. Otherwise, use the modern WebAuthn process way. > > I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process. Fixed. rdar://problem/70822834 Created attachment 412679 [details]
Patch for landing
Committed r269168: <https://trac.webkit.org/changeset/269168> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412679 [details]. |