Bug 218064

Summary: Web Inspector: REGRESSION(r266074): Sources: icon for non-JavaScript breakpoints doesn't change when breakpoints are globally disabled
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 215362    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Devin Rousso 2020-10-21 18:14:25 PDT 
# STEPS TO REPRODUCE
1. inspect any page
2. add any non-JavaScript breakpoint (e.g. All Listeners)
3. disable breakpoints globally

# EXPECTED
icon next to the breakpoint added in step 2 should go greyscale

# ACTUAL
icon next to the breakpoint added in step 2 is still colored
Comment 1 Devin Rousso 2020-10-21 18:15:35 PDT 
my guess is that this was caused by r266074
Comment 2 Devin Rousso 2020-10-21 18:16:18 PDT 
Created attachment 412055 [details]
Patch
Comment 3 Joseph Pecoraro 2020-10-22 09:49:24 PDT 
Comment on attachment 412055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412055&action=review

r=me

> Source/WebInspectorUI/ChangeLog:12
> +        Add `get resolved` to the base class based on `WI.debuggerManager.breakpointsEnabled`. Use

What causes the entire sidebar to update status when the global state changes?
Comment 4 Devin Rousso 2020-10-22 13:06:42 PDT 
Comment on attachment 412055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412055&action=review

>> Source/WebInspectorUI/ChangeLog:12
>> +        Add `get resolved` to the base class based on `WI.debuggerManager.breakpointsEnabled`. Use
> 
> What causes the entire sidebar to update status when the global state changes?

Each `WI.BreakpointTreeElement` adds a listener for `WI.DebuggerManager.Event.BreakpointsEnabledDidChange`, which uses `get resolved` in the handler `updateStatus`.

`WI.SourcesNavigationSidebarPanel` also has it's own listener for `WI.DebuggerManager.Event.BreakpointsEnabledDidChange` that updates the button and the "breakpoints disabled" banner at the top, but that's separate.
Comment 5 EWS 2020-10-22 13:09:07 PDT 
Committed r268885: <https://trac.webkit.org/changeset/268885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412055 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-22 13:10:24 PDT 
<rdar://problem/70586182>