Bug 218060

Summary: [LFC][IFC] Handle line box sizing quirks at the line box level
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Description zalan 2020-10-21 16:45:16 PDT
and not by stretching the inline level boxes
Comment 1 zalan 2020-10-21 17:29:44 PDT
Created attachment 412053 [details]
Patch
Comment 2 zalan 2020-10-21 19:01:18 PDT
*** Bug 217941 has been marked as a duplicate of this bug. ***
Comment 3 zalan 2020-10-21 19:01:50 PDT
Created attachment 412058 [details]
Patch
Comment 4 Antti Koivisto 2020-10-22 06:09:16 PDT
Comment on attachment 412058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412058&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:359
> +            if (inlineLevelBox.isEmpty())
> +                return false;
> +            return quirks.shouldInlineLevelBoxStretchLineBox(lineBox, inlineLevelBox);

maybe the inlineLevelBox.isEmpty() test could go to the quirk too so the lambda would go away?
Comment 5 zalan 2020-10-22 06:17:46 PDT
Created attachment 412088 [details]
Patch
Comment 6 zalan 2020-10-22 06:21:06 PDT
Created attachment 412090 [details]
Patch
Comment 7 EWS 2020-10-22 07:44:03 PDT
Committed r268864: <https://trac.webkit.org/changeset/268864>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412090 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-22 07:45:31 PDT
<rdar://problem/70573591>