| Summary: | [webkitpy] Use webkitcorepy's autoinstaller for chrome and gecko drivers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214950 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathan Bedard
2020-10-21 16:45:13 PDT
Created attachment 412050 [details]
Patch
Created attachment 412108 [details]
Patch
Both of these patches work, I'm just not sure which approach I like better. One is more clear that web drivers are not actually pip packages, at the cost of making accessing the web drivers less portable, while the other pretends that web drivers are pip packages in exchange for making them portable. Comment on attachment 412050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412050&action=review > Tools/Scripts/webkitpy/autoinstalled/chromedriver.py:37 > + response = requests.get(self.URL + 'LATEST_RELEASE') Should we handle the case when requests.get throws an exception? > Tools/Scripts/webkitpy/autoinstalled/chromedriver.py:54 > + link='{url}{version}/chromedriver_{os}.zip'.format( How about making it one-liner, like: link = '{}{}/chromedriver_{}.zip'.format(self.URL, version, os) > Tools/Scripts/webkitpy/autoinstalled/chromedriver.py:56 > + version=str(version), str might not be required here with format() rs=me Created attachment 412133 [details]
Patch for landing
Committed r268896: <https://trac.webkit.org/changeset/268896> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412133 [details]. |