Bug 218056

Summary: Update and pass new URL web platform tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, clopez, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Description Alex Christensen 2020-10-21 15:51:44 PDT
Update and pass new URL web platform tests
Comment 1 Alex Christensen 2020-10-21 16:00:30 PDT
Created attachment 412041 [details]
Patch
Comment 2 Alex Christensen 2020-10-21 17:04:44 PDT
Created attachment 412049 [details]
Patch
Comment 3 EWS Watchlist 2020-10-21 17:05:36 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Tim Horton 2020-10-21 22:05:24 PDT
Comment on attachment 412049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412049&action=review

> Source/WebCore/ChangeLog:8
> +        Don't add an exttra forward slash at the beginning when setting the path of a file URL

Exttra

> LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json:1685
> +                "pathname": "////"

What
Comment 5 Alex Christensen 2020-10-21 22:21:20 PDT
Comment on attachment 412049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412049&action=review

>> LayoutTests/imported/w3c/web-platform-tests/url/resources/setters_tests.json:1685
>> +                "pathname": "////"
> 
> What

The URL specification recently changed normalization of slashes with nothing between them after file: to match what all browsers were doing.  This is the result of that change.  We pass most and this code change makes us pass all the new ones.
Comment 6 Alex Christensen 2020-10-21 22:25:04 PDT
http://trac.webkit.org/r268853
Comment 7 Radar WebKit Bug Importer 2020-10-21 22:26:21 PDT
<rdar://problem/70560548>