Bug 218049

Summary: [webkitpy] Use webkitcorepy's autoinstaller for beautifulsoup
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, ews-watchlist, glenn, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214950
Attachments:
Description Flags
Patch none

Description Jonathan Bedard 2020-10-21 13:23:55 PDT
Part of removing webkitpy's autoinstaller in favor of webkitcorepy's.
Comment 1 Radar WebKit Bug Importer 2020-10-21 13:24:18 PDT
<rdar://problem/70542684>
Comment 2 Jonathan Bedard 2020-10-21 13:26:57 PDT
Created attachment 412023 [details]
Patch
Comment 3 Aakash Jain 2020-10-21 14:54:19 PDT
Comment on attachment 412023 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412023&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:-111
> -    def _install_pytest(self):

is this pytest removal intentional?
Comment 4 Jonathan Bedard 2020-10-21 16:12:01 PDT
(In reply to Aakash Jain from comment #3)
> Comment on attachment 412023 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412023&action=review
> 
> > Tools/Scripts/webkitpy/thirdparty/__init__.py:-111
> > -    def _install_pytest(self):
> 
> is this pytest removal intentional?

Yes! We removed the auto installer for pytest a few weeks back, forgot to delete the function.
Comment 5 EWS 2020-10-21 16:26:13 PDT
Committed r268844: <https://trac.webkit.org/changeset/268844>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412023 [details].