| Summary: | [LFC][IFC] Apply font line-spacing to <br> inline level box | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-10-21 11:55:51 PDT
Created attachment 412014 [details]
Patch
Comment on attachment 412014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=412014&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:183 > + auto lineSpacing = isRootInlineBox(inlineLevelBox) || inlineLevelBox.isLineBreakBox() ? fontMetrics.lineSpacing() - logicalHeight : InlineLayoutUnit(); I usually put parenthesis around this sort of things `(a || b) ? :` since it can be difficult to parse otherwise (or just put the condition to a temporary). (In reply to Antti Koivisto from comment #2) > Comment on attachment 412014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=412014&action=review > > > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:183 > > + auto lineSpacing = isRootInlineBox(inlineLevelBox) || inlineLevelBox.isLineBreakBox() ? fontMetrics.lineSpacing() - logicalHeight : InlineLayoutUnit(); > > I usually put parenthesis around this sort of things `(a || b) ? :` since it > can be difficult to parse otherwise (or just put the condition to a > temporary). good point. will fix. Created attachment 412021 [details]
Patch
Committed r268823: <https://trac.webkit.org/changeset/268823> All reviewed patches have been landed. Closing bug and clearing flags on attachment 412021 [details]. |