Bug 218028

Summary: Simplify ScriptExecutionContext::vm()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, kangil.han, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=218057
Bug Depends on:    
Bug Blocks: 217724    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-10-21 08:50:59 PDT 
Simplify ScriptExecutionContext::vm().
Comment 1 Chris Dumez 2020-10-21 08:51:39 PDT 
Created attachment 411992 [details]
Patch
Comment 2 EWS 2020-10-21 09:40:50 PDT 
Committed r268801: <https://trac.webkit.org/changeset/268801>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411992 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-21 09:41:20 PDT 
<rdar://problem/70532783>
Comment 4 Sam Weinig 2020-10-21 15:24:43 PDT 
Comment on attachment 411992 [details]
Patch

I feel like this would be even better as a pure-virtual function that the subclasses would implement. That would avoid one virtual function call in the worker/worklet case as well.
Comment 5 Chris Dumez 2020-10-21 15:27:29 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 411992 [details]
> Patch
> 
> I feel like this would be even better as a pure-virtual function that the
> subclasses would implement. That would avoid one virtual function call in
> the worker/worklet case as well.

Good idea. I will look into this shortly.
Comment 6 Sam Weinig 2020-10-21 15:33:38 PDT 
(In reply to Chris Dumez from comment #5)
> (In reply to Sam Weinig from comment #4)
> > Comment on attachment 411992 [details]
> > Patch
> > 
> > I feel like this would be even better as a pure-virtual function that the
> > subclasses would implement. That would avoid one virtual function call in
> > the worker/worklet case as well.
> 
> Good idea. I will look into this shortly.

👍
Comment 7 Chris Dumez 2020-10-21 16:10:32 PDT 
(In reply to Sam Weinig from comment #6)
> (In reply to Chris Dumez from comment #5)
> > (In reply to Sam Weinig from comment #4)
> > > Comment on attachment 411992 [details]
> > > Patch
> > > 
> > > I feel like this would be even better as a pure-virtual function that the
> > > subclasses would implement. That would avoid one virtual function call in
> > > the worker/worklet case as well.
> > 
> > Good idea. I will look into this shortly.
> 
> 👍

https://bugs.webkit.org/show_bug.cgi?id=218057