| Summary: | Share more code between WorkerGlobalScope and WorkletGlobalScope | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 217980 | ||||||
| Bug Blocks: | 217724, 217058, 218051 | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2020-10-20 15:41:05 PDT
Created attachment 411941 [details]
Patch
Ping review? Comment on attachment 411941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review > Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57 > + virtual void prepareForDestruction(); protected? Comment on attachment 411941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411941&action=review > Source/WebCore/Modules/webaudio/AudioWorkletThread.cpp:90 > + workletGlobalScope.prepareForDestruction(); See here. >> Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:57 >> + virtual void prepareForDestruction(); > > protected? No, I don't think we can because it is called from WorkerThread / AudioWorkletThread. Committed r268822: <https://trac.webkit.org/changeset/268822> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411941 [details]. |