Bug 217987

Summary:

REGRESSION (r268483): Map jumps around while zooming on windy.com, strava.com

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=217997

Attachments:

Description	Flags
Test	none
Patch	simon.fraser: review+, ews-feeder: commit-queue-

Description Antoine Quint 2020-10-20 14:11:20 PDT

Load windy.com, and zoom the map in and out with up/down scroll gestures on the trackpad. The map jumps around, seemingly using the wrong zoom origin.

Comment 1 Antoine Quint 2020-10-20 14:11:42 PDT

<rdar://problem/70418548>

Comment 2 Antoine Quint 2020-10-20 14:13:17 PDT

Created attachment 411914 [details]
Test

The issue is that when several animations for the same property targeting the same layer are added at the same time, we used to always override the previous animations and now, for transform animations, we actually use additivity over the previous animations.

Comment 3 Antoine Quint 2020-10-20 14:38:47 PDT

Created attachment 411917 [details]
Patch

Comment 4 Simon Fraser (smfr) 2020-10-20 14:41:21 PDT

Comment on attachment 411917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411917&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2960
> +            // animations created for a single KeyframeEffect, one for each trasnform component. In that

trasnform

Comment 5 Antoine Quint 2020-10-20 15:58:56 PDT

Committed r268771: <https://trac.webkit.org/changeset/268771>