Bug 217957

Summary: TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2020-10-20 08:13:27 PDT
[5187/5225] Building CXX object Tools/...WebKitTestRunner.dir/TestOptions.cpp.o
In file included from ../../Tools/WebKitTestRunner/TestOptions.cpp:29:
DerivedSources/WebKitTestRunner/TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
   30 | #define GENERATED_WEB_PREFERENCE_KEY_TYPE_MAPPINGS \
      |

I guess this is bad because something else from another header could be on the next line, depending on the order that headers get included into the source file.
Comment 1 Michael Catanzaro 2020-10-20 08:15:19 PDT
Created attachment 411866 [details]
Patch
Comment 2 Sam Weinig 2020-10-20 09:24:55 PDT
Thanks.
Comment 3 EWS 2020-10-20 10:06:02 PDT
Committed r268740: <https://trac.webkit.org/changeset/268740>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411866 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-20 10:07:35 PDT
<rdar://problem/70489878>