| Summary: | [MotionMark] Add state change items to represent changes to stroke and fill state | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2020-10-19 10:49:03 PDT
Created attachment 411802 [details]
Patch
Comment on attachment 411802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411802&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409 > + Color m_color; > + float m_thickness { 0 }; > + bool m_hasColor { false }; > + bool m_hasThickness { false }; Are you doing it this way, rather than Optional<>, for better packing? (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 411802 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411802&action=review > > > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409 > > + Color m_color; > > + float m_thickness { 0 }; > > + bool m_hasColor { false }; > > + bool m_hasThickness { false }; > > Are you doing it this way, rather than Optional<>, for better packing? Yep! (as explained in the ChangeLog) Comment on attachment 411802 [details]
Patch
Thanks for the review!
Committed r268704: <https://trac.webkit.org/changeset/268704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411802 [details]. |