| Summary: | Import speech tests from WPT | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||||||
| Component: | Tools / Tests | Assignee: | Sihui Liu <sihui_liu> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | clopez, ews-watchlist, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sihui Liu
2020-10-19 10:41:20 PDT
Created attachment 411763 [details]
Patch
Comment on attachment 411763 [details] Patch r=me. Would be good to be able to run the tests that do not crash or time out, even if they fail. View in context: https://bugs.webkit.org/attachment.cgi?id=411763&action=review > LayoutTests/TestExpectations:176 > +imported/w3c/web-platform-tests/speech-api/ [ Skip ] Can we enable them in some cocoa TestExpectations? > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechRecognition-onresult-manual.https.html:1 > +<!DOCTYPE html> Probably not needed. The importer is expected to not import these, maybe the https prefix is messing things up. > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-ownership.html:22 > +}, 'Using the same SpeechSynthesisUtterance with two SpeechSynthesis instances'); Can we check in some expected.txt files? Created attachment 411778 [details]
Patch
(In reply to youenn fablet from comment #2) > Comment on attachment 411763 [details] > Patch > > r=me. > Would be good to be able to run the tests that do not crash or time out, > even if they fail. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411763&action=review > > > LayoutTests/TestExpectations:176 > > +imported/w3c/web-platform-tests/speech-api/ [ Skip ] > > Can we enable them in some cocoa TestExpectations? > Okay, enabled on iOS and mac. > > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechRecognition-onresult-manual.https.html:1 > > +<!DOCTYPE html> > > Probably not needed. > The importer is expected to not import these, maybe the https prefix is > messing things up. > I manually removed the -manual test files. > > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-ownership.html:22 > > +}, 'Using the same SpeechSynthesisUtterance with two SpeechSynthesis instances'); > > Can we check in some expected.txt files? Added. Created attachment 411824 [details]
Patch
Created attachment 411830 [details]
Patch for landing
Created attachment 411831 [details]
Patch for landing
Committed r268713: <https://trac.webkit.org/changeset/268713> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411831 [details]. |