| Summary: | Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aakash_jain, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2020-10-17 10:45:29 PDT
Created attachment 411671 [details]
Patch
Created attachment 411672 [details]
Patch
Created attachment 411673 [details]
Patch
Comment on attachment 411673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411673&action=review > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259 > +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs. Is 'retain' the behavior of the existing code, or should this be 'copy'? (In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 411673 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411673&action=review > > > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259 > > +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs. > > Is 'retain' the behavior of the existing code, or should this be 'copy'? It's the existing behavior (that one was already an @property), but it should probably be copy. Committed r268646: <https://trac.webkit.org/changeset/268646> |