Bug 217874

Summary:

[LFC][Integration] Enable inline image support

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, ews-watchlist, glenn, jbedard, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

217902, 218712

Bug Blocks:

217757

Attachments:

Description	Flags
for bots	ews-feeder: commit-queue-
for bots	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
for bots	ews-feeder: commit-queue-
for bots	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
for bots	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Antti Koivisto 2020-10-17 07:21:14 PDT

Enable

Comment 1 Antti Koivisto 2020-10-17 07:24:57 PDT

Created attachment 411667 [details]
for bots

Comment 2 Antti Koivisto 2020-10-17 12:04:09 PDT

Created attachment 411674 [details]
for bots

Comment 3 zalan 2020-10-17 14:55:24 PDT

Created attachment 411679 [details]
Patch

Comment 4 zalan 2020-10-17 16:43:03 PDT

Created attachment 411687 [details]
Patch

Comment 5 zalan 2020-10-17 20:32:00 PDT

Created attachment 411697 [details]
Patch

Comment 6 zalan 2020-10-18 06:14:06 PDT

Created attachment 411702 [details]
Patch

Comment 7 Antti Koivisto 2020-10-19 04:17:13 PDT

Created attachment 411732 [details]
for bots

Comment 8 Antti Koivisto 2020-10-19 07:04:53 PDT

Created attachment 411744 [details]
for bots

Comment 9 zalan 2020-10-19 15:12:43 PDT

Created attachment 411805 [details]
Patch

Comment 10 zalan 2020-10-19 21:04:25 PDT

Created attachment 411836 [details]
Patch

Comment 11 zalan 2020-10-20 09:02:36 PDT

Created attachment 411870 [details]
Patch

Comment 12 zalan 2020-10-20 13:11:56 PDT

Created attachment 411904 [details]
Patch

Comment 13 zalan 2020-10-20 15:12:04 PDT

Created attachment 411924 [details]
Patch

Comment 14 zalan 2020-10-20 17:33:16 PDT

Created attachment 411942 [details]
Patch

Comment 15 zalan 2020-10-20 19:07:26 PDT

Created attachment 411948 [details]
Patch

Comment 16 zalan 2020-10-22 08:21:52 PDT

Created attachment 412098 [details]
Patch

Comment 17 zalan 2020-10-22 20:30:14 PDT

Created attachment 412152 [details]
Patch

Comment 18 Radar WebKit Bug Importer 2020-10-24 07:22:17 PDT

<rdar://problem/70649950>

Comment 19 Antti Koivisto 2020-10-26 05:00:34 PDT

Created attachment 412307 [details]
for bots

Comment 20 zalan 2020-10-26 12:40:00 PDT

Created attachment 412347 [details]
Patch

Comment 21 zalan 2020-10-30 17:08:52 PDT

Created attachment 412816 [details]
Patch

Comment 22 zalan 2020-10-31 07:41:59 PDT

Created attachment 412840 [details]
Patch

Comment 23 zalan 2020-11-03 08:02:25 PST

Created attachment 413059 [details]
Patch

Comment 24 Antti Koivisto 2020-11-08 06:53:45 PST

Comment on attachment 412840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412840&action=review

> Source/WebCore/ChangeLog:8
> +        EWS.

eww

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:45
> +#define ALLOW_IMAGES 1

Nice!

Comment 25 zalan 2020-11-08 12:14:21 PST

Created attachment 413545 [details]
Patch

Comment 26 zalan 2020-11-09 11:32:05 PST

Created attachment 413607 [details]
Patch

Comment 27 EWS 2020-11-09 13:42:09 PST

Committed r269600: <https://trac.webkit.org/changeset/269600>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413607 [details].