Bug 217856

Summary: webkitcorepy: Allow one package to require another package
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, dpino, ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217659
https://bugs.webkit.org/show_bug.cgi?id=217650
https://bugs.webkit.org/show_bug.cgi?id=217826
https://bugs.webkit.org/show_bug.cgi?id=217694
https://bugs.webkit.org/show_bug.cgi?id=215895
Attachments:
Description Flags
Patch
none
Patch none

Description Lauro Moura 2020-10-16 16:36:20 PDT
webkitcorepy: Allow one package to require another package
Comment 1 Lauro Moura 2020-10-16 16:49:12 PDT
Created attachment 411630 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-16 16:54:23 PDT
Comment on attachment 411630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411630&action=review

> Tools/Scripts/webkitpy/__init__.py:54
> +AutoInstall.register(Package('pytest', Version(3, 6, 2), implicit_deps=['pytest_timeout']))

I'm not against this, although I recently added a feature (for things like zone.interface) that might be easier.  Does this work:

AutoInstall.register(Package('pytest', Version(3, 6, 2))
AutoInstall.register(Package('pytest_timeout', Version(1, 4, 2), pypi_name='pytest-timeout', aliases=['pytest']))
Comment 3 Lauro Moura 2020-10-16 21:27:20 PDT
Created attachment 411654 [details]
Patch
Comment 4 EWS 2020-10-18 20:46:04 PDT
Committed r268662: <https://trac.webkit.org/changeset/268662>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411654 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-18 20:47:20 PDT
<rdar://problem/70426657>