| Summary: | Support accelerated animation of individual transform CSS properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, sergio, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=221054 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 178117 | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2020-10-16 14:22:29 PDT
Created attachment 411617 [details]
Patch
Comment on attachment 411617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411617&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2893 > + animation.m_beginTime = Seconds::fromNanoseconds(1); Why not zero? not that it matters (In reply to Dean Jackson from comment #4) > Comment on attachment 411617 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411617&action=review > > > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2893 > > + animation.m_beginTime = Seconds::fromNanoseconds(1); > > Why not zero? not that it matters Because the CA API gives special meaning to zero in this context, using the current time when the CA transaction occur. We need this time to be as early as possible explicitly. Committed r268615: <https://trac.webkit.org/changeset/268615> (In reply to Antoine Quint from comment #6) > Committed r268615: <https://trac.webkit.org/changeset/268615> As indicated by EWS, these tests are failing on Mojave bots now that the change landed: webanimations/accelerated-transform-related-animation-property-order.html webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html webanimations/accelerated-translate-animation-with-transform.html webanimations/accelerated-translate-animation.html https://build.webkit.org/results/Apple-Mojave-Release-WK2-Tests/r268619%20(16992)/results.html Updated Test Expectations to skip these tests on Mojave. r268627 (In reply to Dean Jackson from comment #8) > Updated Test Expectations to skip these tests on Mojave. > > r268627 Thanks! These are image failures, so we’ll need to switch this from Failure to ImageOnlyFailure. I can fix it up later tonight. Why is it OK to break Mojave? That suggests the patch is wrong. Like maybe this breaks the !HAVE_CA_WHERE_ADDITIVE_TRANSFORMS_ARE_REVERSED platforms. Most likely, I’ll install Mojave and fix those ASAP. Also Windows is broken. |