| Summary: | WebRTC VP9 Decoder should be able to use VTB | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
youenn fablet
2020-10-16 05:09:30 PDT
Created attachment 411558 [details]
Patch
Created attachment 411559 [details]
Patch
Created attachment 411562 [details]
Patch
Created attachment 411563 [details]
Patch
Created attachment 411729 [details]
Patch
Created attachment 411730 [details]
Patch
Created attachment 411742 [details]
Patch
Comment on attachment 411742 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411742&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:81 > + 64, //sizeof(WebKitVP9Decoder), Is this necessary? > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:65 > + return nullptr; Is it worth logging here? > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:70 > + return nullptr; Ditto Created attachment 411989 [details]
Patch for landing
Committed r268805: <https://trac.webkit.org/changeset/268805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411989 [details]. |