Bug 217809

Summary: [GPU Process] Exchange RemoteImageBuffer and RemoteImageBufferProxy
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: CanvasAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, mkwst, philipj, ryuan.choi, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217342    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Said Abou-Hallawa
Reported 2020-10-15 22:22:34 PDT
The ImageBuffer is a WebCore object. We inherit from it for different reasons and we allow different backends for all of the derived classes. For GPU rendering, we currently create an object of type RemoteImageBufferProxy in the GPU Process to own the backend. And to have access to this object, we create another object of type RemoteImageBuffer in the Web Process. The two classes, RemoteImageBufferProxy and RemoteImageBuffer, provide a seamlessly interface in WebCore. So the clients do not have to worry about when the rendering will take place to the backend in the GPU process. But the names of the GPU rendering classes have been confusing. RemoteImageBuffer should be the real object in the GPU Process because it owns the backend. And RemoteImageBufferProxy should be a proxy to this object in the Web Process. So we are going to exchange the following classes: RemoteImageBuffer <-> RemoteImageBufferProxy RemoteRenderingBackend <-> RemoteRenderingBackendProxy RemoteImageBufferMessageHandler <-> RemoteImageBufferMessageHandlerProxy
Attachments
Patch (145.15 KB, patch)
2020-10-15 22:28 PDT, Said Abou-Hallawa
ews-feeder: commit-queue-
Patch (79.73 KB, patch)
2020-10-16 00:28 PDT, Said Abou-Hallawa
no flags
Patch (146.65 KB, patch)
2020-10-16 00:54 PDT, Said Abou-Hallawa
no flags
Patch (80.29 KB, patch)
2020-10-16 01:12 PDT, Said Abou-Hallawa
no flags
Patch (146.65 KB, patch)
2020-10-16 12:45 PDT, Said Abou-Hallawa
no flags
Patch (145.61 KB, patch)
2020-10-16 14:00 PDT, Said Abou-Hallawa
no flags
Patch (145.61 KB, patch)
2020-10-16 14:25 PDT, Said Abou-Hallawa
no flags
Said Abou-Hallawa
Comment 1 2020-10-15 22:28:08 PDT
Said Abou-Hallawa
Comment 2 2020-10-16 00:28:12 PDT
Said Abou-Hallawa
Comment 3 2020-10-16 00:54:05 PDT
Said Abou-Hallawa
Comment 4 2020-10-16 01:12:08 PDT
EWS
Comment 5 2020-10-16 12:22:00 PDT
Tools/Scripts/svn-apply failed to apply attachment 411544 [details] to trunk. Please resolve the conflicts and upload a new patch.
Said Abou-Hallawa
Comment 6 2020-10-16 12:45:32 PDT
Said Abou-Hallawa
Comment 7 2020-10-16 14:00:21 PDT
Said Abou-Hallawa
Comment 8 2020-10-16 14:25:40 PDT
EWS
Comment 9 2020-10-16 15:21:02 PDT
Committed r268612: <https://trac.webkit.org/changeset/268612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411614 [details].
Radar WebKit Bug Importer
Comment 10 2020-10-16 15:22:43 PDT
Note You need to log in before you can comment on or make changes to this bug.