| Summary: | Drop legacy code using AssertionServices | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, darin, ews-watchlist, ggaren, jer.noble, sam, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2020-10-15 14:53:57 PDT
Created attachment 411495 [details]
Patch
Comment on attachment 411495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411495&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; Maybe use &&? Hmm. Looks like our iOS EWS is still running iOS 13 and is thus having a bad time... I guess I need to wait until our bots are all upgraded to iOS 14. Created attachment 411795 [details]
Patch
Comment on attachment 411795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411795&action=review > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; Maybe && (In reply to Darin Adler from comment #6) > Comment on attachment 411795 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411795&action=review > > > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352 > > + return m_rbsAssertion ? m_rbsAssertion.get().valid : false; > > Maybe && Oh, I missed that. Will fix. Created attachment 411800 [details]
Patch
Committed r268736: <https://trac.webkit.org/changeset/268736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411800 [details]. |