Bug 217781

Summary: [macOS] Issue temporary sandbox extension to the Launch Services daemon
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2020-10-15 13:57:37 PDT 
To support blocking of the Launch Services daemon in the WebContent process, issue temporary sandbox extension to this service on macOS.
Comment 1 Radar WebKit Bug Importer 2020-10-15 13:58:10 PDT 
<rdar://problem/70350924>
Comment 2 Per Arne Vollan 2020-10-15 14:19:52 PDT 
Created attachment 411487 [details]
Patch
Comment 3 Per Arne Vollan 2020-10-15 15:46:50 PDT 
Created attachment 411500 [details]
Patch
Comment 4 Brent Fulgham 2020-10-15 16:13:32 PDT 
Comment on attachment 411500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411500&action=review

r=me

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:290
> +

Can you add a FIXME here?

FIXME (<rdar://problem/70345312): Notify LaunchServices that we will be disconnecting.
Comment 5 Per Arne Vollan 2020-10-15 17:03:05 PDT 
Created attachment 411512 [details]
Patch
Comment 6 Per Arne Vollan 2020-10-15 17:13:04 PDT 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 411500 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411500&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:290
> > +
> 
> Can you add a FIXME here?
> 
> FIXME (<rdar://problem/70345312): Notify LaunchServices that we will be
> disconnecting.

I have uploaded a new patch with the FIXME.

Thanks for reviewing!
Comment 7 EWS 2020-10-15 18:07:32 PDT 
Committed r268567: <https://trac.webkit.org/changeset/268567>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411512 [details].