| Summary: | [GStreamer] Audio worklet support | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, calvaris, cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, philipj, sergio, vjaquez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=217699 | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2020-10-15 09:47:28 PDT
Created attachment 411447 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Created attachment 411448 [details]
Patch
Comment on attachment 411448 [details]
Patch
LGTM but maybe Carlos or anybody else wants to review something more.
Comment on attachment 411448 [details]
Patch
Why do we need a setting for this in the API? Why is it disabled by default?
(In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 411448 [details] > Patch > > Why do we need a setting for this in the API? Why is it disabled by default? It's an experimental feature, currently. I don't think we want this enabled by default yet. I don't think we should use API settings to expose experimental features. Ah, I missed #217708 where this was enabled. Removing the setting then. Committed r268579: <https://trac.webkit.org/changeset/268579> |