| Summary: | Vectorize downmixing in AudioBus::createByMixingToMono() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sam, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212611 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2020-10-14 18:11:05 PDT
Created attachment 411391 [details]
Patch
Comment on attachment 411391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411391&action=review > Source/WebCore/platform/audio/VectorMath.cpp:697 > + VectorMath::add(inputVector1, inputVector2, outputVector, numberOfElementsToProcess); > + VectorMath::multiplyByScalar(outputVector, scalar, outputVector, numberOfElementsToProcess); We are in the VectorMath namespace, so no need to restate the namespace as a prefix. Created attachment 411393 [details]
Patch
Committed r268505: <https://trac.webkit.org/changeset/268505> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411393 [details]. |